MiniAOD: fix bug in charge()

[arizzi]

fix sign of leptons in miniaod packed candidates

[arizzi]

@gpetruc

[cmsbuild]

A new Pull Request was created by @arizzi for CMSSW_7_5_X.

fix bug in charge

It involves the following packages:

DataFormats/PatCandidates

@cmsbuild, @vadler, @nclopezo, @monttj can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[TaiSakuma]

The commit seems correct for e, mu, tau.

However, I think that the charge will be opposite for W. I think that +24 is W+ and -24 is W-.

[arizzi]

I think you are right, I just fixed the fact that they were giving always -1.

[arizzi]

btw... I doubt we have W in packedCandidates!

[cmsbuild]

Pull request #8570 was updated. @cmsbuild, @vadler, @nclopezo, @monttj can you please check and sign again.

[davidlange6]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

-1
Tested at: 1c8155f
I found an error when building:

>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-03-27-2300/src/PhysicsTools/PatAlgos/plugins/PATPhotonProducer.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-03-27-2300/src/PhysicsTools/PatAlgos/plugins/PATPhotonSlimmer.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-03-27-2300/src/PhysicsTools/PatAlgos/plugins/PATPrimaryVertexCleaner.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-03-27-2300/src/PhysicsTools/PatAlgos/plugins/PATSecondaryVertexSlimmer.cc 
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-03-27-2300/src/PhysicsTools/PatAlgos/plugins/PATPhotonProducer.cc: In member function 'virtual void pat::PATPhotonProducer::produce(edm::Event&, const edm::EventSetup&)':
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-03-27-2300/src/PhysicsTools/PatAlgos/plugins/PATPhotonProducer.cc:361:15: error: 'class pat::Photon' has no member named 'setEcalPFClusterIso'
       aPhoton.setEcalPFClusterIso((_ecalPFClusterIsoMapH)[photonRef]);
               ^
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-03-27-2300/src/PhysicsTools/PatAlgos/plugins/PATPhotonProducer.cc:362:15: error: 'class pat::Photon' has no member named 'setHcalPFClusterIso'
       aPhoton.setHcalPFClusterIso((_hcalPFClusterIsoMapH)[photonRef]);
               ^


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8570/3892/summary.html

[arizzi]

is the IB broken? how can the change of 4 signs in an accessor have any effect on that producer?

[davidlange6]

yes, it is.. i just fixed it

---

From: arizzi [notifications@github.com]
Sent: 28 March 2015 15:31
To: cms-sw/cmssw
Cc: David Lange
Subject: Re: [cmssw] MiniAOD: fix bug in charge() (#8570)

is the IB broken? how can the change of 4 signs in an accessor have any effect on that producer?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/8570#issuecomment-87236000.

[arizzi]

can some L2 or above retrigger jenkins tests?

[davidlange6]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

-1
Tested at: 1c8155f
I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 24 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

Entering library rule at PhysicsTools/PatAlgos
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-03-28-2300/src/RecoMET/METPUSubtraction/plugins/GBRForestWriter.cc 
In file included from RecoEgammaElectronIdentification/a/RecoEgammaElectronIdentification_xr.cc:41:
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-03-28-2300/src/RecoEgamma/ElectronIdentification/src/classes.h:4:
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-03-28-2300/src/RecoEgamma/ElectronIdentification/interface/VersionedGsfElectronSelector.h:6:
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-03-28-2300/src/PhysicsTools/SelectorUtils/interface/VersionedSelector.h:104:31: error: typename is allowed for identifiers only
  using typename Selector::operator();
        ~~~~~~~~~             ^
warning: unknown warning option '-Wno-psabi' [-Wunknown-warning-option]
1 warning generated.
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-03-28-2300/src/RecoMET/METPUSubtraction/plugins/JVFJetIdProducer.cc 


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8570/3898/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8570/3898/summary.html