Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated soft electron dR cut to better match the jet size #8581

Conversation

ferencek
Copy link
Contributor

Updating the soft electron dR cut from 0.5 to 0.4 to better match the jet size.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_7_4_X.

Updated soft electron dR cut to better match the jet size

It involves the following packages:

RecoBTag/SoftLepton

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@ferencek, @acaudron, @pvmulder, @imarches this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Mar 30, 2015

@cmsbuild please test
we also need a 75X version of this

Also, this feature looks more like an improvement than a normal bugfix. Is it fixing some issue found during 74X validation?

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@ferencek
Copy link
Contributor Author

The soft muon and soft electron taggers select leptons in different ways. While muons are selected from the jet constituents, electrons are selected by matching gedGsfElectrons to jets. So the soft muon tagger does not apply an explicit dR requirement but its effective value is 0.4 (ignoring special cases of overlapping jets, etc.). This PR therefore makes the lepton selection more consistent between the two taggers. In terms of the performance, it is expected to get slightly worse for low-pT jets. So this PR probably goes more into the category of bugfixes than performance improvements.

A 75X version will follow.

@cmsbuild
Copy link
Contributor

-1
Tested at: ce5e5aa
The relvals timed out after 2 hours.

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8581/3943/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Apr 1, 2015
…MSSW_7_4_0_pre9

Updated soft electron dR cut to better match the jet size
@cmsbuild cmsbuild merged commit c0dd25a into cms-sw:CMSSW_7_4_X Apr 1, 2015
@ferencek ferencek deleted the SoftElectronDRUpdate_from-CMSSW_7_4_0_pre9 branch April 1, 2015 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants