Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow compilation by robot in 75X #8590

Merged

Conversation

gzevi
Copy link
Contributor

@gzevi gzevi commented Mar 30, 2015

Found during #8493 that robot was not able to compile 75X with:
git cms-addpkg DataFormats/PatCandidates
git cms-addpkg RecoEgamma/ElectronIdentification
scram b vclean && scram build -k -j 24 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

@lgray suggested to remove "typename" from a line in VersionedSelector.h.
Compilation worked fine after this change.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gzevi for CMSSW_7_5_X.

allow compilation by robot in 75X

It involves the following packages:

PhysicsTools/SelectorUtils

@cmsbuild, @vadler, @nclopezo, @monttj can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

davidlange6 added a commit that referenced this pull request Apr 2, 2015
@davidlange6 davidlange6 merged commit cae94be into cms-sw:CMSSW_7_5_X Apr 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants