Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New HF Shower Library interface for FastSim #8591

Merged
merged 3 commits into from Apr 2, 2015

Conversation

Vlandr57
Copy link
Contributor

This is version of HF Shower Library interface for FastSim which allows
to use all necessary functions from FullSim Shower Library.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Vlandr57 for CMSSW_7_5_X.

New HF Shower Library interface for FastSim

It involves the following packages:

FastSimulation/Calorimetry
FastSimulation/ShowerDevelopment
SimG4CMS/Calo

@ssekmen, @nclopezo, @lveldere, @civanch, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @matt-komm, @makortel this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@lveldere
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-1
Tested at: f7f031a
I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 8 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/external/boost/1.51.0-cms2/include/boost/bind/arg.hpp:37:22: warning: unused typedef 'T_must_be_placeholder' [-Wunused-local-typedef]
        typedef char T_must_be_placeholder[ I == is_placeholder::value? 1: -1 ];
                     ^
2 warnings generated.
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-03-29-2300/src/FastSimulation/EventProducer/src/FamosManager.cc 
clang: error: unknown argument: '-fipa-pta'
clang: error: unknown argument: '-fipa-pta'
gmake: **\* [tmp/slc6_amd64_gcc491/src/FastSimulation/EventProducer/src/FastSimulationEventProducer/FamosManager.o] Error 1
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-03-29-2300/src/FastSimulation/EventProducer/src/FamosProducer.cc 
clang: error: unknown argument: '-fipa-pta'
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-03-29-2300/src/SimG4CMS/HcalTestBeam/plugins/HcalTB04Analysis.cc 


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8591/3985/summary.html

@lveldere
Copy link
Contributor

+1

no regression expected, no regression observed

@civanch
Copy link
Contributor

civanch commented Apr 1, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants