Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove asserts in hcal tp emulator #8597

Merged
merged 2 commits into from Mar 31, 2015

Conversation

akhukhun
Copy link
Contributor

Remove asserts to check the tp presample and size.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @akhukhun for CMSSW_7_3_X.

remove asserts in hcal tp emulator

It involves the following packages:

SimCalorimetry/HcalTrigPrimAlgos

@cmsbuild, @nclopezo, @mulhearn can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@mulhearn
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@abdoulline
Copy link

Please, consider it for the next 735 patch release...

@davidlange6
Copy link
Contributor

@akhukhun - what is the 74x/75x version of this PR?

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants