Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedup expression evaluator unit test #8628

Merged

Conversation

VinInn
Copy link
Contributor

@VinInn VinInn commented Apr 1, 2015

it seems to time out in jenkins

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2015

A new Pull Request was created by @VinInn (Vincenzo Innocente) for CMSSW_7_5_X.

Speedup expression evaluator unit test

It involves the following packages:

CommonTools/Utils

@nclopezo, @cvuosalo, @monttj, @cmsbuild, @slava77, @vadler can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@davidlange6
Copy link
Contributor

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2015

-1

Tested at: 70fe1dc
I found errors in the following unit tests:

---> test testExpressionEvaluator had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8628/4059/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2015

@cvuosalo
Copy link
Contributor

cvuosalo commented Apr 2, 2015

@VinInn:
At the beginning of the Jenkins unit tests there seems to be an error (shown below). Does this error indicate a serious problem? Is it related to this PR?

Thread model: posix
gcc version 4.9.1 (GCC)
|

|9cbdb90202574e03851a114e3902d00c
|

|sh: notexisting: command not found

@cvuosalo
Copy link
Contributor

cvuosalo commented Apr 2, 2015

+1

For #8628 349fe9d

Fix for Jenkins time-out.

The code changes are satisfactory, and Jenkins test results against baseline CMSSW_7_5_X_2015-04-02-1100 show no problems, other than the unit test error message mentioned above that is probably not significant.

@VinInn
Copy link
Contributor Author

VinInn commented Apr 3, 2015

@cvuosalo: is expected. means it works correctly! maybe I will add a comment next iteration

davidlange6 added a commit that referenced this pull request Apr 3, 2015
@davidlange6 davidlange6 merged commit 8494437 into cms-sw:CMSSW_7_5_X Apr 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants