Consumes interface for TrackerHitAssociator #8647
Conversation
|
A new Pull Request was created by @wmtan for CMSSW_7_5_X. Consumes interface for TrackerHitAssociator It involves the following packages: SimTracker/TrackerHitAssociation @civanch, @nclopezo, @danduggan, @mdhildreth, @cmsbuild, @deguio can you please review it and eventually sign? Thanks. |
wmtan
force-pushed
the
ConsumesForTrackerHitAssociator
branch
from
da68ea1
to
aa04902
Compare
|
Pull request #8647 was updated. @civanch, @nclopezo, @danduggan, @mdhildreth, @cmsbuild, @deguio can you please check and sign again. |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
|
+1 |
Consumes interface for TrackerHitAssociator
|
@wmtan , there is a memory leak identified in 750pre2, detailed analysis is in https://hypernews.cern.ch/HyperNews/CMS/get/relval/3565/1/1/1/1/1/1.html |
|
Hi Dmitrijus,
I've submitted PR 8819 to implement the "trivial" fix you offer, since I
sense that finding some solution is urgent. I'm not so much of a c++
master as to digest immediately the changes that have been made to
implement the consumes interface or look for a better solution.
Regarding the deprecated functions, as Bill Tanenbaum explained in his
PR comment, the prereq for removing these is to fix all the consumers of
this class. Some time back I made an attempt to identify these with a
string search on the class name and found a lot of hits. Many of them
were only in comments or stale includes of the header. If there's any
way to find the ones that really use this class I'd like to know it.
I'd be happy to help with this if I have someone to work with to fill in
the gaps in my understanding.
Bill
|
|
DXR (which doesn't seem to have been well publicized) can find each place where a function is called. In this case the two constructors for TrackerHitAssocciators which don't use the ConsumesCollector: |
|
Hi Chris, Thanks much. Is there some way to specify the CMSSW release? Some Bill On 04/22/2015 12:14 PM, Chris Jones wrote:
|
|
I would be happy to work on cleaning this up after I am back from vacation (May 5). |
|
DXR was updated to the most recent 7_5_X IB. It is also available from LXR page http://cmslxr.fnal.gov/lxr/index.html |
This pull request implements the consumes interface in class TrackerHitAssociator, which involves adding to one existing constructor and adding two new functions, one public. Other very minor optimizations were also made to this class.
This pull request also modifies six modules to use the new TrackerHitAssociator interface so that all products read by the TrackerHitAssociator will be read by getByToken, and therefore registered with the consumes interface. These modules include all five such modules that are known to be used in the relvals.
Note that the current interface to TrackerHitAssociator was left unchanged because many other modules still use it, although comments were added indicating that it is deprecated.