bsunanda:Run2-alca7 Correct the destructors and a few constructors and a few python scripts ...

[bsunanda]

Changes to satisfy some of the coding conventions and to match AlCa requirements for getting the right conditions

[cmsbuild]

A new Pull Request was created by @bsunanda for CMSSW_7_5_X.

bsunanda:Run2-alca7 Correct the destructors and a few constructors and a few python scripts ...

It involves the following packages:

Calibration/HcalAlCaRecoProducers
Calibration/HcalCalibAlgos
Calibration/HcalIsolatedTrackReco
DQMOffline/CalibCalo
DataFormats/HcalIsolatedTrack

@diguida, @cvuosalo, @cerminar, @cmsbuild, @nclopezo, @deguio, @slava77, @mmusich, @danduggan can you please review it and eventually sign? Thanks.
@rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[bsunanda]

I rebased all the changes in previous PR (#8347) to CMSSW_7_5_X_2015-04-02-1100 and made this PR and I checked that it gives 0 errors for "runTheMatrix.py -s --useInput all"

---

From: cmsbuild [notifications@github.com]
Sent: 02 April 2015 23:36
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] bsunanda:Run2-alca7 Correct the destructors and a few constructors and a few python scripts ... (#8649)

A new Pull Request was created by @bsunandahttps://github.com/bsunanda for CMSSW_7_5_X.

bsunanda:Run2-alca7 Correct the destructors and a few constructors and a few python scripts ...

It involves the following packages:

Calibration/HcalAlCaRecoProducers
Calibration/HcalCalibAlgos
Calibration/HcalIsolatedTrackReco
DQMOffline/CalibCalo
DataFormats/HcalIsolatedTrack

@diguidahttps://github.com/diguida, @cvuosalohttps://github.com/cvuosalo, @cerminarhttps://github.com/cerminar, @cmsbuildhttps://github.com/cmsbuild, @nclopezohttps://github.com/nclopezo, @deguiohttps://github.com/deguio, @slava77https://github.com/slava77, @mmusichhttps://github.com/mmusich, @dandugganhttps://github.com/danduggan can you please review it and eventually sign? Thanks.
@rociovilarhttps://github.com/rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezohttps://github.com/nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/8649#issuecomment-89051129.

[cvuosalo]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

-1
Tested at: 4be422f
When I ran the RelVals I found an error in the following worklfows:
4.53 step4

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT+MINIAODDreHLT/step4_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT+MINIAODDreHLT.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8649/3151/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

[davidlange6]

+1