Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Fireworks dictionary generation to ROOT6 #8662

Merged
merged 4 commits into from May 3, 2015
Merged

Migrate Fireworks dictionary generation to ROOT6 #8662

merged 4 commits into from May 3, 2015

Conversation

alja
Copy link
Contributor

@alja alja commented Apr 3, 2015

This is a new attempt of changes in #8660

@alja
Copy link
Contributor Author

alja commented Apr 3, 2015

+1

@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Apr 3, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2015

+1
Tested at: f166f6f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8662/4093/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

@alja
Copy link
Contributor Author

alja commented Apr 7, 2015

+1
added minor bugfix

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

@alja
Copy link
Contributor Author

alja commented Apr 23, 2015

This changes should not go in 7_4_X_ROOT5 branch.

@alja alja mentioned this pull request Apr 23, 2015
Merged
@alja
Copy link
Contributor Author

alja commented Apr 24, 2015

This is an important change. Without it Fireworks event display cannot function with ROOT6.

@nclopezo
Copy link
Contributor

#8886 will prevent that this changes go in the CMSSW_7_4_ROOT5_X branch.

@alja
Copy link
Contributor Author

alja commented Apr 27, 2015

@nclopezo
Would it be any easier if I would make this pull request for CMSSW_7_4_ROOT6_X ?

nclopezo added a commit that referenced this pull request Apr 28, 2015
@nclopezo
Merge pull request #8886 from nclopezo/avoid-merge-8662
7c43be5 
Avoid merge of  #8662
@nclopezo
Copy link
Contributor

Hi @alja
It is not necessary, the CMSSW_7_4_ROOT6_X is not being used any more. CMSSW_7_4_X is root 6 and it has automatic forward port to CMSSW_7_4_ROOT5_X. After I merged #8886, when the automatic forward port executes, the CMSSW_7_4_ROOT5_X branch will not receive the changes from this PR.

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request May 3, 2015
@cmsbuild
Merge pull request #8662 from alja/fwdict6-74
014ad1c 
Migrate Fireworks dictionary generation to ROOT6
@cmsbuild cmsbuild merged commit 014ad1c into cms-sw:CMSSW_7_4_X May 3, 2015
@alja alja deleted the fwdict6-74 branch May 11, 2017 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-pending fully-signed tests-approved visualization-approved
Projects
None yet
Milestone
Next CMSSW_7_4_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alja @cmsbuild @nclopezo @davidlange6