Macros need to compile in ROOT6 (Reco)

[wmtan]

In ROOT6 macros are processed by cling, rather than CINT. Over 500 CMSSW macros do not compile in ROOT6. Since that is too many macros to be fixed centrally, it was decided by David Lange to centrally fix only those 45 macros with compilation errors that have been modified since the switch over to git, since those are the ones most likely to be used. A few of these 45 macros are in the Reconstruction L2 category. This pull request partially fixes the compilation errors. I could not fully fix RecoParticleFlow/PFClusterTools/test/src/testWrappers.C, because I could not find any place in CMSSW where type "SingleParticleWrapper" was declared. I chose not to fix RecoParticleFlow/PFClusterTools/test/src/clusterCalibrate.C because its only problem is that a constructor that it needs, pftools::PFClusterCalibration(pftools::IO *) has been commented out. Since it may have been commented out for a good reason, I left this alone. To fix this macro, simply uncomment the constructor.

[cmsbuild]

A new Pull Request was created by @wmtan for CMSSW_7_5_X.

Macros need to compile in ROOT6 (Reco)

It involves the following packages:

RecoParticleFlow/PFClusterTools
RecoTracker/TrackProducer

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @mmarionncern, @makortel, @GiacomoSguazzoni, @rovere, @lgray, @appeltel, @mschrode, @gpetruc, @cerati, @VinInn, @dgulhan, @bachtis, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[slava77]

@cmsbuild please test
[this may be pointless since the scripts are not compiled by scram]

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: f93745b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8715/4194/summary.html

[slava77]

+1

for #8715 f93745b
changes in the code are as expected.
They all looks like they can go to the root5 version as well

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

[wmtan]

Since Slava is correct that it appears these changes are harmless for ROOT5, I removed the request to not forward these to 7_5_ROOT5_X from the original comment.

[davidlange6]

+1

[wmtan]

These changes are harmless for ROOT5.