Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in PVAssignment: missing abs for dxy #8721

Merged
merged 2 commits into from Apr 16, 2015

Conversation

arizzi
Copy link
Contributor

@arizzi arizzi commented Apr 14, 2015

This fixes the bug found by @VinInn of missing abs in PV association

Same PR will be made for 74X

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @arizzi for CMSSW_7_5_X.

Fix bug in PVAssignment: missing abs for dxy

It involves the following packages:

CommonTools/RecoAlgos

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@ahinzmann, @jdolen, @rappoccio, @abbiendi, @jhgoh this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Apr 14, 2015

@cmsbuild please test

@slava77
Copy link
Contributor

slava77 commented Apr 14, 2015

@cmsbuild please test
trying one more time

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Apr 15, 2015

+1

for #8721 17da848
this is the same topic branch/the same code change as in #8722 prepared for 74X.

See that thread for the review discussion and approval summary.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants