Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC DQM Fix for summary plots and DCS bit in 74X #8730

Merged
merged 1 commit into from May 20, 2015

Conversation

acimmino
Copy link
Contributor

Contains:

  1. Important fixes for offline summary plots.
  2. Removed dependency on DCS bit.
  3. Fix to rpc event counter histograms
  4. Fix for when RPCs are excluded from the run

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @acimmino (Anna Cimmino) for CMSSW_7_4_X.

RPC DQM Fix for summary plots and DCS bit in 74X

It involves the following packages:

DQM/RPCMonitorClient
DQM/RPCMonitorDigi

@cmsbuild, @danduggan, @nclopezo, @deguio can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Apr 15, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor

deguio commented Apr 20, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

@acimmino
Copy link
Contributor Author

Hi,
It looks like this pull request is still open. Is there a problem or is it only a matter of being patient?
Thanks,
Anna

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants