Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fixes in CSC (ME11) trigger primitives for re-emulation; fix ME11 selective readout (fw port of 73X #8664 ) #8751

Merged
merged 11 commits into from Apr 21, 2015

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented Apr 15, 2015

this is the same as #8750 (the same branch, the same commits)

This is supposed to address issues with running CSC (ME11 part) emulator on run2 data (currently broken for ME11a) and for re-emulation applications of run2 MC (currently possible from sim digis, but appears to be less convenient than done from RAW).
Additionally, the selective readout for run2 MC was fixed (currently the CSC selective readout emulation is disabled in run2 MC; everything is saved.)

full message is in #8750

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slava77 (Slava Krutelyov) for CMSSW_7_5_X.

bug fixes in CSC (ME11) trigger primitives for re-emulation; fix ME11 selective readout (fw port of 73X #8664 )

It involves the following packages:

DataFormats/L1CSCTrackFinder
EventFilter/CSCRawToDigi
L1Trigger/CSCCommonTrigger
L1Trigger/CSCTriggerPrimitives

@cmsbuild, @cvuosalo, @nclopezo, @mulhearn, @slava77 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @valuev, @barvic this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor Author

slava77 commented Apr 15, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@slava77
Copy link
Contributor Author

slava77 commented Apr 15, 2015

+1

for #8751 16b7332
this is the same topic branch in git as used for #8750 16b7332
signing off based on jenkins comparisons there: expected behavior: no changes in the reconstructed objects; several DQM plots related to ME11 trigger primitives now correctly display ME1a and ME1b contributions (in the CSCOfflineMonitor plots)

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8751/7165/summary.html

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

@davidlange6
Copy link
Contributor

approved already in 73x - so should be fine for 75x... merging

davidlange6 added a commit that referenced this pull request Apr 21, 2015
bug fixes in CSC (ME11) trigger primitives for re-emulation; fix ME11 selective readout (fw port of 73X #8664 )
@davidlange6 davidlange6 merged commit 39b780a into cms-sw:CMSSW_7_5_X Apr 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants