Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECAL unpacker: consider the ADC hysteresis in the gain switches #8759

Merged

Conversation

emanueledimarco
Copy link
Contributor

In the previous version a gain switch error was triggered as soon as there was a transition from a higher gainID (lower gain) to a lower gain ID (higher gain).
The ADC, though, has an hysteresis of 5 samples, after which this transition back to a lower gain ID is allowed, after the first gain switch.

This is considered to happen in a tiny number of events. The effect of this change should be almost invisible in data relvals.

@grasph @argiro @ferriff please also follow this

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @emanueledimarco (Emanuele Di Marco) for CMSSW_7_5_X.

ECAL unpacker: consider the ADC hysteresis in the gain switches

It involves the following packages:

EventFilter/EcalRawToDigi

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Apr 16, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Apr 16, 2015

+1

for #8759 aa95ff9
code changes are the same as in #8760 60b7752
signed off for 74X

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Apr 16, 2015
…tch_750pre2

ECAL unpacker: consider the ADC hysteresis in the gain switches
@cmsbuild cmsbuild merged commit 99c984a into cms-sw:CMSSW_7_5_X Apr 16, 2015
@emanueledimarco emanueledimarco deleted the ecalunpacker_fixgainswitch_750pre2 branch June 16, 2015 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants