New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ECAL unpacker: consider the ADC hysteresis in the gain switches #8759
ECAL unpacker: consider the ADC hysteresis in the gain switches #8759
Conversation
A new Pull Request was created by @emanueledimarco (Emanuele Di Marco) for CMSSW_7_5_X. ECAL unpacker: consider the ADC hysteresis in the gain switches It involves the following packages: EventFilter/EcalRawToDigi @cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
+1 |
…tch_750pre2 ECAL unpacker: consider the ADC hysteresis in the gain switches
In the previous version a gain switch error was triggered as soon as there was a transition from a higher gainID (lower gain) to a lower gain ID (higher gain).
The ADC, though, has an hysteresis of 5 samples, after which this transition back to a lower gain ID is allowed, after the first gain switch.
This is considered to happen in a tiny number of events. The effect of this change should be almost invisible in data relvals.
@grasph @argiro @ferriff please also follow this