Hcal noise filters backport #8805
Conversation
…Run 2 but not 50 ns Run 2
|
A new Pull Request was created by @igv4321 for CMSSW_7_4_X. Hcal noise filters backport It involves the following packages: CommonTools/RecoAlgos @civanch, @nclopezo, @cvuosalo, @mdhildreth, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
| @@ -49,6 +49,8 @@ def customisePostLS1(process): | |||
| # 25ns specific customisation | |||
| if hasattr(process,'digitisation_step'): | |||
| process = customise_Digi_25ns(process) | |||
| if hasattr(process,'dqmoffline_step'): | |||
| process = customise_DQM_25ns(process) | |||
There was a problem hiding this comment.
why not do the same in 75X?
There was a problem hiding this comment.
Yes, will eventually do the same in 75X. The proper Run 2 config wasn't obvious when the implementation was originally discussed.
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar |
|
Comparison is ready The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons |
|
+1 |
Backporting PR #8685
Compared to PR #8685, there is a minor difference in the config files -- the "HBHENoiseFilterResultRun2Loose" flag is made default only for 25 ns Run 2 rather than for the whole Run 2. For 50 ns Run 2 we still use "HBHENoiseFilterResultRun1".