Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TrackerHitAssociator clear maps each new event #8819

Merged
merged 2 commits into from Apr 23, 2015

Conversation

wmtford
Copy link
Contributor

@wmtford wmtford commented Apr 22, 2015

Just implement the minimal fix suggested by Dmitrijus to prevent the memory leak from the TrackerHitAssociator in CMSSW_7_5_0_pre2. I'll need to invest some effort to understand the consumes changes made by David Lange and Bill Tanenbaum, before attempting any more ambitious cure. I also haven't tested anything beyond compilation. So I leave to reviewers to decide whether to go with this PR as a quick fix or look for something better.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtford (Bill Ford) for CMSSW_7_5_X.

TrackerHitAssociator clear maps each new event

It involves the following packages:

SimTracker/TrackerHitAssociation

@cmsbuild, @civanch, @nclopezo, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @GiacomoSguazzoni, @rovere, @VinInn, @appeltel, @cerati, @threus, @dgulhan, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@civanch
Copy link
Contributor

civanch commented Apr 22, 2015

please test

@civanch
Copy link
Contributor

civanch commented Apr 22, 2015

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@cmsbuild
Copy link
Contributor

-1
Tested at: baf3799
you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8819/4345/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@Dr15Jones
Copy link
Contributor

The failure was due to DAS

davidlange6 added a commit that referenced this pull request Apr 23, 2015
TrackerHitAssociator clear maps each new event
@davidlange6 davidlange6 merged commit 6ededad into cms-sw:CMSSW_7_5_X Apr 23, 2015
@wmtford wmtford deleted the assocClearMaps branch April 23, 2015 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants