Switching 50 ns Run 2 configuration of HCAL noise filters to Run 1 mode

[igv4321]

As the title mentions. Consistent with PR #8805.

[cmsbuild]

A new Pull Request was created by @igv4321 for CMSSW_7_5_X.

Switching 50 ns Run 2 configuration of HCAL noise filters to Run 1 mode

It involves the following packages:

CommonTools/RecoAlgos
SLHCUpgradeSimulations/Configuration

@civanch, @nclopezo, @cvuosalo, @mdhildreth, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @jdolen, @makortel, @abbiendi, @jhgoh, @Martin-Grunewald, @ahinzmann this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: 5c88a01
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8833/4347/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

[davidlange6]

+1

[Martin-Grunewald]

This gives me an error, presumably because the function customise_DQM_25ns is
used/called before it is defined.

Creating RECO+VALIDATION+DQM GRun_MC
RAW2DIGI,L1Reco,RECO,VALIDATION,DQM,ENDJOB
entry file:RelVal_DigiL1RawHLT_GRun_MC.root
Step: RAW2DIGI Spec: 
Step: L1Reco Spec: 
Step: RECO Spec: 
Step: VALIDATION Spec: 
 in preparing validation
Step: DQM Spec: 
Step: ENDJOB Spec: 
# Conditions read from  CMS_CONDITIONS  via FrontierProd 
customising the process with Base from HLTrigger/Configuration/CustomConfigs
customising the process with customisePostLS1 from SLHCUpgradeSimulations/Configuration/postLS1Customs
Traceback (most recent call last):
  File "/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_5_X_2015-04-23-2300/bin/slc6_amd64_gcc491/cmsDriver.py", line 43, in <module>
    run()
  File "/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_5_X_2015-04-23-2300/bin/slc6_amd64_gcc491/cmsDriver.py", line 15, in run
    configBuilder.prepare()
  File "/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_5_X_2015-04-23-2300/python/Configuration/Applications/ConfigBuilder.py", line 2188, in prepare
    self.pythonCfgCode += self.addCustomise()
  File "/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_5_X_2015-04-23-2300/python/Configuration/Applications/ConfigBuilder.py", line 869, in addCustomise
    self.process=getattr(package,fcn)(self.process)
  File "/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_5_X_2015-04-23-2300/python/SLHCUpgradeSimulations/Configuration/postLS1Customs.py", line 53, in customisePostLS1
    process = customise_DQM_25ns(process)
NameError: global name 'customise_DQM_25ns' is not defined

[Martin-Grunewald]

OK, David mentioned a race condition...