Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to Pandora recipe with no fragment removal algorithms #8856

Merged
merged 1 commit into from Apr 24, 2015

Conversation

kpedro88
Copy link
Contributor

This commit adds a modified Pandora recipe with no fragment removal algorithms, and sets it as the default recipe in the python configuration. This increases the speed of Pandora in high-pileup environments with little effect on the jet resolution, see attached slides:

hgcal pandora jer nofragremoval 2
hgcal pandora jer nofragremoval 3

attn: @lgray, @vandreev11, @pfs, @boudoul

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_6_2_X_SLHC.

switch to Pandora recipe with no fragment removal algorithms

It involves the following packages:

RecoParticleFlow/PandoraTranslator

The following packages do not have a category, yet:

RecoParticleFlow/PandoraTranslator

@cmsbuild, @nclopezo can you please review it and eventually sign? Thanks.
@mmarionncern, @bachtis, @lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mark-grimes
Copy link

Do you want this as the default for all pileup scenarios? We could put something in the customisation that checks what pileup it is and decide which config to run.

@kpedro88
Copy link
Contributor Author

I'm not sure what would be best at this moment. @lgray, @vandreev11, what do you think?

@lgray
Copy link
Contributor

lgray commented Apr 23, 2015

Busy right now, back to you later tonight.

(Sent from my Nexus 6)
On Apr 23, 2015 6:54 PM, "Kevin Pedro" notifications@github.com wrote:

I'm not sure what would be best at this moment. @lgray
https://github.com/lgray, @vandreev11 https://github.com/vandreev11,
what do you think?


Reply to this email directly or view it on GitHub
#8856 (comment).

@vandreev11
Copy link
Contributor

On my opinion it should be the same for all PU scenarios. PU0 could be a special case, but it is better to avoid that for the sake of comparisons, drawing conclusions. I believe it is temporary measure, clustering in Pandora needs to be tuned yet for high pileup case.

@lgray
Copy link
Contributor

lgray commented Apr 24, 2015

Along the same lines as Valeri, since we're going to be doing a massive
overhaul of the clustering to begin with, perhaps it is better to keep
things configured the same with the stock pandora algorithms for all PU
scenarios.

We'll likely still be using some of the linear collider algorithms even
after we've finished developing specialized clustering/ID/PF, so it's good
to keep configurations straightforward and simple.

-L

(Sent from my Nexus 6)
On Apr 24, 2015 06:25, "vandreev11" notifications@github.com wrote:

On my opinion it should be the same for all PU scenarios. PU0 could be a
special case, but it is better to avoid that for the sake of comparisons,
drawing conclusions. I believe it is temporary measure, clustering in
Pandora needs to be tuned yet for high pileup case.


Reply to this email directly or view it on GitHub
#8856 (comment).

@mark-grimes
Copy link

merge

Okay, so that's everything for the next patch release right? Getting on a plane now, I'll put in the build request when I land.

cmsbuild added a commit that referenced this pull request Apr 24, 2015
switch to Pandora recipe with no fragment removal algorithms
@cmsbuild cmsbuild merged commit fa65f7f into cms-sw:CMSSW_6_2_X_SLHC Apr 24, 2015
@kpedro88
Copy link
Contributor Author

Yes, that should be everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants