Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FWCore/Services: do not optimize 'edmtest::FpeTester::analyze' #8892

Merged
merged 1 commit into from Apr 30, 2015

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Apr 28, 2015

Resolves unit test (fpe_test_2.sh) failure in CLANG IB.

Completed cmsRun with DIVIDEBYZERO exception enabled
cmsRun status:  0
Test FAILED, status neither 136 nor 11
status = 256

do_division call is optimized out from edmtest::FpeTester::analyze.
It's caused by division by zero, which is undefined behavior thus
compiler is free to do what it wants, e.g., optimize it out.

Disable any optimizations on the function.

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlt for CMSSW_7_5_X.

FWCore/Services: do not optimize 'edmtest::FpeTester::analyze'

It involves the following packages:

FWCore/Services

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit, @wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

-1
Tested at: 3b2d740
you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8892/4411/summary.html

@davidlt
Copy link
Contributor Author

davidlt commented Apr 28, 2015

This does not affect relvals and all failures are Step0-DAS_ERROR.

@@ -54,6 +54,7 @@ namespace edmtest {
}

void
__attribute__((optnone))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use the C++11 syntax instead? [[optnone]]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After looking carefully into Clang testsuite, I found [[clang::optnone]], but I don't know how GCC (or other compilers) would handle that.

Resolves unit test (`fpe_test_2.sh`) failure in CLANG IB.

    Completed cmsRun with DIVIDEBYZERO exception enabled
    cmsRun status:  0
    Test FAILED, status neither 136 nor 11
    status = 256

`do_division` call is optimized out from `edmtest::FpeTester::analyze`.
It's caused by division by zero, which is undefined behavior thus
compiler is free to do what it wants, e.g., optimize it out.

Disable any optimizations on the function.

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@davidlt
Copy link
Contributor Author

davidlt commented Apr 29, 2015

Updated. Seems to work with GCC, but Clang was picky about attribute location. Even ICC was happy!

@Dr15Jones
Copy link
Contributor

pleaset test

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8892/4467/summary.html

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants