Updated implementation of the HCAL negative energy filter

[igv4321]

The filter is disabled for now, pending DropBox support for HBHENegativeEFilter objects.

Also, added a few forgotten "delete" statements to the HcalHitReconstructor destructor.

[cmsbuild]

A new Pull Request was created by @igv4321 for CMSSW_7_5_X.

Updated implementation of the HCAL negative energy filter

It involves the following packages:

RecoLocalCalo/HcalRecAlgos
RecoLocalCalo/HcalRecProducers

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[slava77]

[code looks ok at the quick glance; will need to double-check with static analyzer]

[cmsbuild]

+1
Tested at: 4c6c7ec
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8923/8744/summary.html

[igv4321]

The severity level settings for NEF are described in slide 24 of
https://indico.cern.ch/event/381507/contribution/1/material/slides/0.pdf

[slava77]

So,
HcalRemoveAddSevLevel.AddFlag(hcalRecAlgos,"HBHENegativeNoise",12) is needed only for 25 ns data, correct?

We need to figure out how to do it.

[igv4321]

Yes, we will figure this out when the time comes to enable the filter. In particular, I'd like to see a statement on the status of "eras" configuration support in 7_5_X and in post-7_4_1.

[slava77]

+1

for #8923 e8b72ee

• code changes are OK
• jenkins tests show no difference as expected, since the feature is not enabled (pending cond DB updates).

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

[davidlange6]

+1