Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fireworks gem 75x #8936

Merged
merged 12 commits into from May 6, 2015
Merged

Fireworks gem 75x #8936

merged 12 commits into from May 6, 2015

Conversation

jshlee
Copy link
Contributor

@jshlee jshlee commented May 1, 2015

Hi @dildick and @alja,

I've updated fireworks for gem and me0 here.

I've added Configuration/Geometry/python/GeometryExtended2023Muon_cff.py and Geometry/CMSCommonData/python/cmsExtendedGeometry2023MuonXML_cfi.py
to be able to use Configuration/Geometry/python/GeometryExtended2023MuonReco_cff.py

and corrected geometry dumpers for gem and me0
I'll give a talk on this in the next validation meeting.

Cheers,
Jason.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2015

A new Pull Request was created by @jshlee (Jason Lee) for CMSSW_7_5_X.

Fireworks gem 75x

It involves the following packages:

Configuration/Geometry
Fireworks/Core
Fireworks/Geometry
Fireworks/Muons
Fireworks/Tracks
Geometry/CMSCommonData
SLHCUpgradeSimulations/Configuration

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @alja, @nclopezo can you please review it and eventually sign? Thanks.
@ghellwig, @alja, @Martin-Grunewald, @makortel this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@alja
Copy link
Contributor

alja commented May 1, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants