Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bsunanda:Run2-alca12 Allow some debugging to the IsoTrack trigger filter code #8950

Merged
merged 2 commits into from May 5, 2015

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented May 4, 2015

Provide debugging to IsoTrack trigger filters

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2015

A new Pull Request was created by @bsunanda for CMSSW_7_5_X.

bsunanda:Run2-alca12 Allow some debugging to the IsoTrack trigger filter code

It involves the following packages:

HLTrigger/special

@Martin-Grunewald, @perrotta, @cmsbuild, @nclopezo, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@fwyzard
Copy link
Contributor

fwyzard commented May 4, 2015

-1

@fwyzard
Copy link
Contributor

fwyzard commented May 4, 2015

@bsunanda , please use LogDebug instead of #ifdef and edm::LogInfo .

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2015

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8950/4528/summary.html

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2015

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8950/20/summary.html

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants