Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testEmptyHist.sh store RECO output in FEVTDEBUGHLT format #8986

Merged
merged 1 commit into from May 19, 2015
Merged

testEmptyHist.sh store RECO output in FEVTDEBUGHLT format #8986

merged 1 commit into from May 19, 2015

Conversation

lveldere
Copy link
Contributor

@lveldere lveldere commented May 7, 2015

No description provided.

@lveldere
Copy link
Contributor Author

lveldere commented May 7, 2015

please test

@lveldere
Copy link
Contributor Author

lveldere commented May 7, 2015

+1

@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone May 7, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2015

A new Pull Request was created by @lveldere for CMSSW_7_5_X.

testEmptyHist.sh store RECO output in FEVTDEBUGHLT format

It involves the following packages:

FastSimulation/Validation

@ssekmen, @nclopezo, @lveldere, @civanch, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @matt-komm this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@lveldere
Copy link
Contributor Author

lveldere commented May 9, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2015

-1

Tested at: 22476dd
I found errors in the following unit tests:

---> test TestIntegrationUnscheduledFailOnOutput had ERRORS
---> test TestIntegrationParameterSet had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8986/1/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
e79ea36
5f7286e
2b7026c
9b5bea3
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8986/1/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8986/1/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

@lveldere
Copy link
Contributor Author

lveldere commented May 9, 2015

@davidlange6

errors are not at all related to the pr

davidlange6 added a commit that referenced this pull request May 19, 2015
…GHLT

testEmptyHist.sh store RECO output in FEVTDEBUGHLT format
@davidlange6 davidlange6 merged commit f3703ce into cms-sw:CMSSW_7_5_X May 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants