Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary fix to clear TrackerHitAssociator maps each event #8990

Merged

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented May 7, 2015

The change to TrackerHitAssociator to support the consumes interface was done in a suboptimal way that, among other things, did not release the PSimHit maps until the beginning of the next event, causing memory issues. This PR is a simple temporary fix to clear the maps at the proper time.
This fix was requested by David Lange.
Since my tests of this PR are still in progress, it would be prudent to test this PR before merging.
NOTE: The consumes interface for TrackerHitAssociator will later be re-implemented in a more robust and less error-prone way very soon.

@Dr15Jones
Copy link
Contributor

please test

@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone May 7, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2015

A new Pull Request was created by @wmtan for CMSSW_7_5_X.

Temporary fix to clear TrackerHitAssociator maps each event

It involves the following packages:

SimTracker/TrackerHitAssociation
Validation/GlobalRecHits
Validation/RecoTrack
Validation/TrackerRecHits

@civanch, @nclopezo, @danduggan, @mdhildreth, @cmsbuild, @deguio can you please review it and eventually sign? Thanks.
@makortel, @GiacomoSguazzoni, @rovere, @VinInn, @appeltel, @wmtford, @cerati, @threus, @dgulhan, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants