Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bsunanda:Run2-hcx10 Port codes to enable full encapsulation of HcalDetId #8998

Merged
merged 5 commits into from May 18, 2015
Merged

bsunanda:Run2-hcx10 Port codes to enable full encapsulation of HcalDetId #8998

merged 5 commits into from May 18, 2015

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented May 7, 2015

This is the first batch of code changes to enable porting of Hcal code from SLHC branch to main branch

@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone May 7, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2015

A new Pull Request was created by @bsunanda for CMSSW_7_5_X.

bsunanda:Run2-hcx10 Port codes to enable full encapsulation of HcalDetId

It involves the following packages:

CalibFormats/HcalObjects
CondFormats/HcalObjects
DataFormats/HcalDetId
SimCalorimetry/HcalTrigPrimAlgos

@civanch, @nclopezo, @mdhildreth, @cmsbuild, @diguida, @cerminar, @ggovi, @mmusich, @mulhearn can you please review it and eventually sign? Thanks.
@apfeiffer1 this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@civanch
Copy link
Contributor

civanch commented May 8, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2015

The tests are being triggered in jenkins.

diguida
diguida reviewed May 8, 2015
View reviewed changes
CalibFormats/HcalObjects/src/HcalCalibrationWidthsSet.cc
if (cell == mItems.end() ||
((fId.det()==DetId::Hcal && HcalDetId(cell->id) != HcalDetId(fId)) ||
(fId.det()==DetId::Calo && fId.subdetId()==HcalZDCDetId::SubdetectorId && HcalZDCDetId(cell->id) != HcalZDCDetId(fId)) ||
(fId.det()!=DetId::Hcal && (fId.det()==DetId::Calo && fId.subdetId()!=HcalZDCDetId::SubdetectorId) && (cell->id != fId))))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsunanda this check is duplicated other times, e.g. here and here and here.
In order to avoid code duplication, can this become a utility function in the Condition package?

@ggovi
Copy link
Contributor

ggovi commented May 18, 2015

+1

davidlange6 added a commit that referenced this pull request May 18, 2015
@davidlange6
Merge pull request #8998 from bsunanda/Run2-hcx10
bef2834 
bsunanda:Run2-hcx10  Port codes to enable full encapsulation of HcalDetId
@davidlange6 davidlange6 merged commit bef2834 into cms-sw:CMSSW_7_5_X May 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-approved comparison-available l1-pending orp-pending pending-signatures simulation-approved tests-approved
Projects
None yet
Milestone
CMSSW_7_5_X
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@bsunanda @cmsbuild @civanch @diguida @abdoulline @ggovi @Dr15Jones @davidlange6