Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EGM VID IDs for 75X - PHYS14 tunings #9002

Merged
merged 80 commits into from Jun 4, 2015

Conversation

lgray
Copy link
Contributor

@lgray lgray commented May 8, 2015

This pull request contains ID definitions for cut based electron and photon IDs.

Expectations:
There is no change to RECO output except for IDs that are embedded in MiniAOD slimmed electrons and photons.

Features:

  • updated workflow to reflects variables that are now embedded in objects (full5x5, etc)
  • Photon cut-based ID working points
  • Contains HEEP V5.1
  • 'beta' version of python and FWLite interface that can be found in PhysicsTools/SelectorUtils/test/pyfwlite_test.py (likely to be in flux for a bit)

VID use in python is available in ROOT5 or ROOT6.

@ikrav @cmkuo

lgray and others added 30 commits April 30, 2015 11:15
…in later CMSSW, close to 7.4.0, but we need the fix earlier than that)
…aps for variables needed by photon MVA as well as automatic detection of AOD vs miniAOD
…ed (it is an optional argument in the constructor with a default uninitialized value)
…proved definition of working points in Python: now less repetitive
… format, and is configured to handle either in the cfi
… when unmentioned, is AOD, but can be set to miniAOD, in which case an appropriate physics objects collection is set.
@monttj
Copy link
Contributor

monttj commented Jun 4, 2015

+1
apologize for the late response.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@lgray
Copy link
Contributor Author

lgray commented Jun 4, 2015

Hooray!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants