Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storing payloads with the related serialization info. Improved error … #9013

Merged
merged 2 commits into from May 11, 2015

Conversation

ggovi
Copy link
Contributor

@ggovi ggovi commented May 8, 2015

…handling in serialization.

This PR is introducing the serialization info in the storage of payloads. The errors in the serialization/de-serialization are interpreted and re-thrown.

@ggovi
Copy link
Contributor Author

ggovi commented May 8, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2015

-1
Tested at: 254d11d
I found an error when building:

>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-05-07-2300/src/Alignment/LaserAlignment/src/LASPeakFinder.cc 
In file included from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc491/external/clhep/2.1.4.1-cms/include/CLHEP/Vector/EulerAngles.h:19:0,
                 from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-05-07-2300/src/CondFormats/Alignment/interface/AlignTransform.h:5,
                 from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-05-07-2300/src/CondFormats/Alignment/interface/Alignments.h:6,
                 from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-05-07-2300/src/Alignment/CocoaFit/src/CocoaDBMgr.cc:1:
/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc491/external/clhep/2.1.4.1-cms/include/CLHEP/Vector/defs.h:41:17: error: expected unqualified-id before string constant
 #define VERSION "2.1.4.1"
                 ^
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-05-07-2300/src/CondCore/CondDB/interface/Serialization.h:95:34: note: in expansion of macro 'VERSION'
     static constexpr char const\* VERSION = BOOST_LIB_VERSION;
                                  ^


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9013/4592/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

@ggovi
Copy link
Contributor Author

ggovi commented May 9, 2015

+1

@ggovi
Copy link
Contributor Author

ggovi commented May 9, 2015

@cmsbuild
please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request May 11, 2015
Storing payloads with the related serialization info. Improved error …
@cmsbuild cmsbuild merged commit bf6ed20 into cms-sw:CMSSW_7_5_X May 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants