Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mask to keep track of all algos where a track is reconstructed (and also move detachedTripletStep right after initialStep in priority order where it should be) Class TkMCQuality is also modified to produce a vector of "qualities" instead of writing a new track collection with a fake quality bit set. #9073

Merged
merged 13 commits into from May 19, 2015

Conversation

VinInn
Copy link
Contributor

@VinInn VinInn commented May 13, 2015

Added a bitset that keep track of all algos a track has been "reconstructed" according to the criteria of the TrackListMerger.
I took the opportunity to fix the algo-priority-order to reflect the actual order in this release.
trackAlgoPriorityOrder.h has been moved to a public header so that it is available also at stages of reconstruction and analysis other than FinalSelectors.
I also modified class TkMCQuality to make it producing a vector of "qualities" instead of writing a new track collection with a fake quality bit set.

All this can be used (among others) to measure the reco efficiency using tag&probe method.
In particular for muon, Iter10 "muonSeededStepOutIn" can be used as a probe to check if the track were found previously.

for instance these are the results on a sample of 2000 boosted Jpsi (particle gun) superimposed to 13TeV pileup (average 35, 25ns)

the first table shows the percentage of reconstructed muon for each couple of algorithms.
The following histograms shows the final assignment to the track as well as which algo found first:
those found first by iter10 are tracker-only inefficiency.
the purple line shows the tracks found only by one algo.
A different view is shown in the second histogram that count how many algo a track has been found in early-iterations. The number of track not found by early-iterations are again the tracker-only inefficiency.

this method of course does not account for tracker-detector inefficiency.
for that standard tag&probe will provide an answer.

jpsialgotable

jpsialgos

jpsicontearly

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @VinInn (Vincenzo Innocente) for CMSSW_7_5_X.

Add mask to keep track all algos where a track is reconstructed

It involves the following packages:

DataFormats/GsfTrackReco
DataFormats/TrackReco
RecoTracker/FinalTrackSelectors

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @appeltel, @mschrode, @gpetruc, @cerati, @dgulhan, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.



#endif
#include "DataFormats/TrackReco/interface/trackAlgoPriorityOrder.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the new file missing perhaps?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was missing indeed...

@VinInn
Copy link
Contributor Author

VinInn commented May 13, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

@VinInn VinInn changed the title Add mask to keep track of all algos where a track is reconstructed (and also move detachedTripletStep right after initialStep in priority order where it should be) Add mask to keep track of all algos where a track is reconstructed (and also move detachedTripletStep right after initialStep in priority order where it should be) Class TkMCQuality is also modified to produce a vector of "qualities" instead of writing a new track collection with a fake quality bit set. May 19, 2015
@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request May 19, 2015
Add mask to keep track of all algos where a track is reconstructed (and also move detachedTripletStep right after initialStep in priority order where it should be) Class TkMCQuality is also modified to produce a vector of "qualities" instead of writing a new track collection with a fake quality bit set.
@cmsbuild cmsbuild merged commit f19dff0 into cms-sw:CMSSW_7_5_X May 19, 2015
cmsbuild added a commit that referenced this pull request Jun 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants