Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alcareco 74x #9085

Merged
merged 11 commits into from Jun 10, 2015
Merged

Fix alcareco 74x #9085

merged 11 commits into from Jun 10, 2015

Conversation

shervin86
Copy link
Contributor

Porting of PR 8306 to CMSSW_7_4_X
Need it asap for alcareco production for low PU runs

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @shervin86 for CMSSW_7_4_X.

Fix alcareco 74x

It involves the following packages:

Calibration/EcalAlCaRecoProducers
Calibration/EcalCalibAlgos
Configuration/AlCa
Configuration/EventContent
Configuration/PyReleaseValidation
Configuration/StandardSequences

@diguida, @boudoul, @franzoni, @cerminar, @cmsbuild, @srimanob, @nclopezo, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald, @makortel, @GiacomoSguazzoni, @rovere, @argiro, @appeltel, @cerati, @VinInn, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mmusich
Copy link
Contributor

mmusich commented May 14, 2015

@cmsbuild please test
@shervin86 please put in the description this is the backport in 7.4.X of #8306

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@shervin86
Copy link
Contributor Author

Test approved, pending signatures

@mmusich
Copy link
Contributor

mmusich commented Jun 9, 2015

@shervin86 do you plan to PR also the new commits (shervin86@a3d96c2, shervin86@358166e, shervin86@5bb55ac ) in 7.5.X?

@shervin86
Copy link
Contributor Author

yes

@diguida
Copy link
Contributor

diguida commented Jun 9, 2015

+1
Back port of the following PR:
#8306
#9256
#9284
#9298
To be moved to 75X too:

@shervin86
Copy link
Contributor Author

I will do the PRs tomorrow
Can pdmv and orp sign?

@shervin86
Copy link
Contributor Author

still pending signatures, please merge it

@davidlange6
Copy link
Contributor

yelling in git won't help much - but as discussed in the ORP, I evaluated how safe this was to backport skipping the usual procedure. I don't see issues so will merge it

davidlange6 added a commit that referenced this pull request Jun 10, 2015
@davidlange6 davidlange6 merged commit d405b67 into cms-sw:CMSSW_7_4_X Jun 10, 2015
@shervin86 shervin86 deleted the fixAlcareco_74x branch November 25, 2016 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants