New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Secondary input source improvements/fixes #9091
Conversation
A new Pull Request was created by @wmtan for CMSSW_7_5_X. Secndary input source improvements/fixes It involves the following packages: IOPool/Input @cmsbuild, @Dr15Jones, @nclopezo can you please review it and eventually sign? Thanks. |
please test |
seed = (seed << 16) + seed; | ||
std::ifstream f("/dev/urandom"); | ||
unsigned int seed; | ||
f.read(reinterpret_cast<char*>(&seed), sizeof(seed)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bbockelm Is this how you expected it to work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup - that's going to be as good as we can make things.
The tests are being triggered in jenkins. |
+1 |
@ericvaandering this should fix the problem you were discussing with Bill. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar |
@davidlange6 @Dr15Jones |
-1 runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50+MINIAODMCUP1550/step2_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50+MINIAODMCUP1550.log ----- Begin Fatal Exception 14-May-2015 20:48:04 CEST----------------------- An exception of category 'Configuration' occurred while [0] Processing run: 1 lumi: 1 event: 1 [1] Running path 'digitisation_step' [2] Calling event method for module MixingModule/'mix' Exception Message: RootInputFileSequence::readOneRandom(): no input files specified for secondary input source. ----- End Fatal Exception ------------------------------------------------- you can see the results of the tests here: |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar |
+1 |
Secondary input source improvements/fixes
I've backported this to 6_2_X_SLHC with #9140. There were some minor clashes with differences between 62X and 75X, if anyone has the time for a cursory glance I'd appreciate you checking over it. |
I looked over #9140 briefly, and it looks OK. I did not notice any obvious differences between 62X and 75X. |
Secondary input source improvements/fixes (backport of #9091)
This PR makes several improvements/fixes to the secondary input source.
This bug is fixed by the same change that implements 1).
Note that 1), and possibly 2), are needed by any reasonable deterministic scheme to avoid duplication of premixed pileup.