Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport RunningAverage and use for PFRecHitProducer reserve #9135

Merged
merged 2 commits into from May 19, 2015

Conversation

mark-grimes
Copy link

This backports edm::RunningAverage from 75X and uses it to guess the size of the PFRecHitProducer collection. There are a loads of plots on #9106 that show the benefit at 200 pileup.
#9106 applies shrink_to_fit on the collection afterwards as well, which might or might not be merged since it increases the peak memory. Using an accurate reserve however gives a clear benefit so I'll add this separately first.

@mark-grimes
Copy link
Author

please test

Forgot to say - the unit test is slightly different because the version of GCC in 6_2_X_SLHC doesn't have thread_local.

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_6_2_X_SLHC.

Backport RunningAverage and use for PFRecHitProducer reserve

It involves the following packages:

FWCore/Utilities
RecoParticleFlow/PFClusterProducer

@nclopezo, @cvuosalo, @cmsbuild, @Dr15Jones, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @wmtan, @makortel, @wddgit, @lgray, @Martin-Grunewald, @bachtis this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mark-grimes
Copy link
Author

merge

Tests seem stuck, but I've tested privately.

cmsbuild added a commit that referenced this pull request May 19, 2015
Backport RunningAverage and use for PFRecHitProducer reserve
@cmsbuild cmsbuild merged commit 8cbb2f7 into cms-sw:CMSSW_6_2_X_SLHC May 19, 2015
@cmsbuild
Copy link
Contributor

@mark-grimes mark-grimes deleted the guessCollectionSizes branch May 19, 2015 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants