Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of the HCAL negative energy filter code #9137

Merged
merged 1 commit into from Jun 15, 2015

Conversation

igv4321
Copy link
Contributor

@igv4321 igv4321 commented May 18, 2015

Backporting PR #8447, #8923, and #9105

The implementation of the negative energy filter was confirmed to be correct by the HCAL Noise WG using a configuration from a private database.

The filter is still not enabled, pending the GT (requested).

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @igv4321 for CMSSW_7_4_X.

Backport of the HCAL negative energy filter code

It involves the following packages:

CondCore/HcalPlugins
CondCore/Utilities
CondFormats/DataRecord
CondFormats/HcalObjects
CondTools/Hcal
RecoLocalCalo/HcalRecAlgos
RecoLocalCalo/HcalRecProducers

@nclopezo, @cvuosalo, @cerminar, @cmsbuild, @diguida, @slava77, @ggovi, @mmusich can you please review it and eventually sign? Thanks.
@ghellwig, @apfeiffer1, @argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented May 18, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@igv4321
Copy link
Contributor Author

igv4321 commented Jun 3, 2015

Please merge this

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants