Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cerr left in inadvertently #9155

Merged
merged 1 commit into from May 19, 2015
Merged

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented May 19, 2015

In a recent improvement, PR #9091, I inadvertently left in a std::cerr statement I used to debug it.
This trivial PR simply removes the statement, which was causing IB logs to fill up.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_5_X.

Remove cerr left in inadvertently

It involves the following packages:

IOPool/Input

@cmsbuild, @Dr15Jones, @nclopezo can you please review it and eventually sign? Thanks.
@wddgit this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor

please test

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

davidlange6 added a commit that referenced this pull request May 19, 2015
Remove cerr left in inadvertently
@davidlange6 davidlange6 merged commit c13b341 into cms-sw:CMSSW_7_5_X May 19, 2015
@wmtan wmtan deleted the cerrRemove branch May 20, 2015 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants