Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DQMOffline egamma electrons updates (74X backport) #9157

Merged
merged 3 commits into from Jun 16, 2015

Conversation

gzevi
Copy link
Contributor

@gzevi gzevi commented May 19, 2015

74X backport of PR #9082

Original comments:

A few more fixes to DQMOffline/Egamma/Electrons (continuation of PR #9010).
Avoid NaNs in m_ee plots (check > 0 before taking square root)
TagAndProbe folder now shows plots (it was empty because of wrong supercluster collection to match with)
Electron selection was not being applied to m_ee plots, so m_ee plot was the same across folders.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gzevi for CMSSW_7_4_X.

DQMOffline egamma electrons updates (74X backport)

It involves the following packages:

DQMOffline/EGamma

@cmsbuild, @danduggan, @nclopezo, @deguio can you please review it and eventually sign? Thanks.
@rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented May 19, 2015

+1

@deguio
Copy link
Contributor

deguio commented May 19, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@gzevi
Copy link
Contributor Author

gzevi commented Jun 3, 2015

@davidlange6, could we ask for your signature here, if you approve the changes?
These DQM Offline plots would be helpful for electron commissioning, and I realized today (looking at stable beams) that they had not yet been merged.
Thank you!

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants