New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DQMOffline egamma electrons updates (74X backport) #9157
DQMOffline egamma electrons updates (74X backport) #9157
Conversation
A new Pull Request was created by @gzevi for CMSSW_7_4_X. DQMOffline egamma electrons updates (74X backport) It involves the following packages: DQMOffline/EGamma @cmsbuild, @danduggan, @nclopezo, @deguio can you please review it and eventually sign? Thanks. |
+1 |
please test |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
@davidlange6, could we ask for your signature here, if you approve the changes? |
+1 |
DQMOffline egamma electrons updates (74X backport)
74X backport of PR #9082
Original comments:
A few more fixes to DQMOffline/Egamma/Electrons (continuation of PR #9010).
Avoid NaNs in m_ee plots (check > 0 before taking square root)
TagAndProbe folder now shows plots (it was empty because of wrong supercluster collection to match with)
Electron selection was not being applied to m_ee plots, so m_ee plot was the same across folders.