clone methods return unique_ptr #9179
Conversation
The static analyzer was complaining that the const clone methods were return bare pointers. Changed to using std::unique_ptr<> instead.
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_5_X. clone methods return unique_ptr It involves the following packages: DataFormats/Common @cmsbuild, @Dr15Jones, @nclopezo can you please review it and eventually sign? Thanks. |
|
please test |
|
+1 |
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar |
|
@cmsbuild, please test |
cmsbuild
added
comparison-pending
core-approved
and removed
comparison-pending
core-approved
fully-signed
orp-pending
tests-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar |
clone methods return unique_ptr
|
Did the tests finish? I really wanted to be sure it compiled using all of CMSSW |
|
no.. i’ll plan for success and deal with the fallout in the morning:)
|
|
Fair enough, hope you have a pleasant morning :) |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
The static analyzer was complaining that the const clone methods were return bare pointers. Changed to using std::unique_ptr<> instead.