Remove obsolete KalmanAlignmentAlgorithm

[VinInn]

Should have been done long (long) ago...

[cmsbuild]

A new Pull Request was created by @VinInn (Vincenzo Innocente) for CMSSW_7_5_X.

Remove obsolete KalmanAlignmentAlgorithm

It involves the following packages:

Alignment/CommonAlignmentProducer
Alignment/KalmanAlignmentAlgorithm

@cmsbuild, @mmusich, @diguida, @cerminar, @nclopezo can you please review it and eventually sign? Thanks.
@ghellwig, @pakhotin, @frmeier, @tlampen, @mschrode, @mmusich this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[mmusich]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: 359622c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9197/9533/summary.html

[diguida]

+1
@VinInn thanks. This was a pending issue...

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

[frmeier]

There is likely more obsolete code related to the Kálmán alignment algorithm. Maybe check the ReferenceTrajectories for classes that were only used by Kálmán. I guess it is worthwhile to review the ReferenceTrajectories and keep only what is used by current algorithms.

[diguida]

@frmeier IIUC the further cleanup you propose is on the interfaces of ReferenceTrajectories related to the Kalman alignment.

[frmeier]

@diguida Yes. I guess one should not withhold this PR and make another one for the interface cleanup.

[diguida]

@frmeier agreed. Indeed I have just given +1 for this. For the interface cleanup, we can think of doing the following:

1. check in the removed packages which interfaces are used exclusively
2. remove them; if it is used elsewhere, compilation will fail.

Any feedback is welcome.

[davidlange6]

+1