Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastSim: fix trackref in ConversionTrackCollection #9202

Merged
merged 6 commits into from May 21, 2015
Merged

FastSim: fix trackref in ConversionTrackCollection #9202

merged 6 commits into from May 21, 2015

Conversation

lveldere
Copy link
Contributor

  • the original ConversionTrackCollection is copied. In the copy, reference to tracks in the before-mixing track collection are replaced with references to the after-mixing track collection
  • the before-mixing track collection is dropped from AODSIM, which is justified by the above
  • should be considered for backporting to 74X as it reduces the AODSIM event content

@lveldere
Copy link
Contributor Author

please test

@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone May 21, 2015
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lveldere for CMSSW_7_5_X.

FastSim: fix trackref in ConversionTrackCollection

It involves the following packages:

FastSimulation/Configuration
FastSimulation/Tracking

@ssekmen, @nclopezo, @lveldere, @civanch, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @matt-komm this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@lveldere
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@lveldere
Copy link
Contributor Author

@davidlange6
I'm checking how much effect this has on the AODSIM file size.
If it's significant enough, I'll prepare a backport for 74X today.

@lveldere
Copy link
Contributor Author

Pretty obvious this needs to be backported:

TTbar, 13 TeV, no PU, AODSIM


  • FullSim: 136 kB / event (3000 events, RelVal)
  • 
FastSim before: 210 kB / event ( 100 events, private)
  • 
FastSim after: 136 kB /event (100 events, private)

The absolute gain (~80 kB / event) is expected to be constant versus PU

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants