Timing improvement for PFEGammaAlgo in HI

[lgray]

Use tactical cache in PFEgammaAlgo to avoid time blow up in HI events.

No changes expected/observed in local tests.
No real timing change in pp. Nice factor of 3 speed up in HI events.

Igprof (using VoronoiBackgroundProducer for normalization, these were done on different systems and different numbers of events):
before:
27.8 479.80 VoronoiBackgroundProducer::produce(edm::Event&, edm::EventSetup const&) [27]
7.2 123.77 PFEGammaProducer::produce(edm::Event&, edm::EventSetup const&) [43]

after:
32.9 823.18 VoronoiBackgroundProducer::produce(edm::Event&, edm::EventSetup const&) [27]
2.8 68.93 PFEGammaProducer::produce(edm::Event&, edm::EventSetup const&) [65]

[cmsbuild]

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_7_5_X.

Timing improvement for PFEGammaAlgo in HI

It involves the following packages:

RecoParticleFlow/PFProducer

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @bachtis this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[lgray]

Ah, I found another place were improvement can be made with a little cache. Testing.

[lgray]

Nope, this is it. Please go ahead with testing on your end.

[cmsbuild]

+1
Tested at: 4bda206
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9283/7862/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9283/7862/summary.html

[cvuosalo]

Timing tests in progress...

[cvuosalo]

+1

For #9283 4bda206

Speed up the PFEGammaAlgo for HI. Should not change monitored quantities.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_5_X_2015-05-26-2300 show no significant differences, as expected. Tests on workflow 140.53_RunHI2011 with 100 events against baseline CMSSW_7_5_X_2015-05-19-2300 also show no significant differences. Timing improvement is notable.

Baseline -> PR:
particleFlowEGamma 8697.61 ms/ev -> 1690.97 ms/ev

Baseline
Max VSIZ 3782.23 on evt 68 ; max RSS 2794.12 on evt 98 (memory in MB)
Time av 54.285 s/evt max 275.109 s on evt 96

PR 9283
Max VSIZ 3859 on evt 38 ; max RSS 2790.59 on evt 96
Time av 47.1024 s/evt max 221.868 s on evt 96

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

[lgray]

Hi Carl,

Could you possibly send an igprof report on the PR version in the test
workflow you used?
It would be useful for further work in speeding things up!

Thanks,
-Lindsey

On Thu, May 28, 2015 at 11:51 AM, Carl Vuosalo notifications@github.com
wrote:

+1

For #9283 #9283 4bda206
4bda206

Speed up the PFEGammaAlgo for HI. Should not change monitored quantities.

The code changes are satisfactory, and Jenkins tests
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9283/7862/summary.html
against baseline CMSSW_7_5_X_2015-05-26-2300 show no significant
differences, as expected. Tests on workflow 140.53_RunHI2011 with 100
events against baseline CMSSW_7_5_X_2015-05-19-2300 also show no
significant differences. Timing improvement is notable.

Baseline -> PR:
particleFlowEGamma 8697.61 ms/ev -> 1690.97 ms/ev

Baseline
Max VSIZ 3782.23 on evt 68 ; max RSS 2794.12 on evt 98 (memory in MB)
Time av 54.285 s/evt max 275.109 s on evt 96

PR 9283
Max VSIZ 3859 on evt 38 ; max RSS 2790.59 on evt 96
Time av 47.1024 s/evt max 221.868 s on evt 96

—
Reply to this email directly or view it on GitHub
#9283 (comment).

[davidlange6]

+1