Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added basicjet template for JetCorrectionProducer (heavy ions hlt use… #9315

Merged
merged 1 commit into from Jun 17, 2015

Conversation

cfmcginn
Copy link
Contributor

…), backport to CMSSW_74

A small modification of SealModules.cc so we can have access to *CorrectionProducer for BasicJet object at HLT (our PF jets w/ subtraction are technically basicJets).

This is a back port of the request in CMSSW_75 found here: #9313

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @cfmcginn (Chris) for CMSSW_7_4_X.

Added basicjet template for JetCorrectionProducer (heavy ions hlt use

It involves the following packages:

JetMETCorrections/Modules

@cmsbuild, @vadler, @nclopezo, @monttj can you please review it and eventually sign? Thanks.
@rappoccio, @ahinzmann, @mmarionncern, @jdolen, @nhanvtran, @schoef, @mariadalfonso, @TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

-1
Tested at: 83d79b3
you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9315/3892/summary.html

@cmsbuild
Copy link
Contributor

@monttj
Copy link
Contributor

monttj commented Jun 8, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@Martin-Grunewald
Copy link
Contributor

I think this is very wrong, as these plugins use the old-style ES based JetCorrections which are
not multi-threading safe. In fact, we migrated HLT already to new-stype EDProducer-based
jetcorrections:

oldToNewProds = {'CaloJetCorrectionProducer':'CorrectedCaloJetProducer','PFJetCorrectionProducer':'CorrectedPFJetProducer'}

Thus defining a BasicJetCorrectionProducer seems outdated and should be fixed properly!

@Martin-Grunewald
Copy link
Contributor

BTW, the HLT summary product packing up 4-momentum of trigger objects
can handle CaloJets and PFJets only. So you either need to convert your
BasicJets into one of those two, or use one of those two from the onset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants