Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consumes migration -- CSCRawToDigi #935

Merged
merged 17 commits into from Sep 27, 2013
Merged

Consumes migration -- CSCRawToDigi #935

merged 17 commits into from Sep 27, 2013

Conversation

ktf
Copy link
Contributor

@ktf ktf commented Sep 27, 2013

This fixes #763 by rebasing it on top of current IB. Only a few comments removed and some indentation changes.

ptcox and others added 17 commits September 9, 2013 16:55
@ptcox
new test on raw relval in 700
e138303
@ptcox
add consumes interface
e046954
@ptcox
add consumes interface
726fa62
@ptcox
add consumes interface
d5103e5
@ptcox
add consumes interface
0876a70
@ptcox
fix typo
9206eea
@ptcox
add consumes interface
e8b6406
@ptcox
add consumes interface
0e60103
@ptcox
add consumes interface
e929626
@ptcox
add consumes interface
d70558e
@ptcox
add consumes interface
bdbbd71
@ptcox
add consumes interface
2fec127
@ptcox
add consumes interface
ff399cf
@ptcox
add consumes interface
a631bbf
@ptcox
add consumes interface
68f5faa
@ptcox
add consumes interface
b49cb73
@ktf
Merged refs/pull/763/head from repository cms-sw
9e2a96d 
Conflicts:
	EventFilter/CSCRawToDigi/interface/CSCDigiValidator.h
	EventFilter/CSCRawToDigi/interface/CSCViewDigi.h
	EventFilter/CSCRawToDigi/plugins/CSCDigiToRawModule.cc
	EventFilter/CSCRawToDigi/plugins/CSCDigiValidator.cc
	EventFilter/CSCRawToDigi/plugins/CSCViewDigi.cc
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_0_X.

Consumes migration -- CSCRawToDigi

It involves the following packages:

RecoLocalMuon/CSCValidation
EventFilter/CSCRawToDigi

@nclopezo, @smuzaffar, @thspeer, @slava77 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@thspeer
Copy link
Contributor

thspeer commented Sep 27, 2013

Working @thspeer

@nclopezo
Copy link
Contributor

+1
https://cmssdt.cern.ch/jenkins/job/Pull-Request-Integration/ARCHITECTURE=slc5_amd64_gcc481/667/console
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/667

@nclopezo
Copy link
Contributor

And you can see here the comparison with the baseline ( CMSSW_7_0_X_2013-09-27-0200+935)

https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_7_0_X_2013-09-27-0200+935/58/

@ktf
Copy link
Contributor Author

ktf commented Sep 27, 2013

The original pull request was already fully signed. I'm bypassing this. @thspeer shout if you think this is wrong.

ktf added a commit that referenced this pull request Sep 27, 2013
@ktf
Merge pull request #935 from ktf/consumes-CSCRawToDigi
20a30f1 
Consumes migration -- CSCRawToDigi
@ktf ktf merged commit 20a30f1 into cms-sw:CMSSW_7_0_X Sep 27, 2013
@ktf ktf deleted the consumes-CSCRawToDigi branch September 27, 2013 10:03
gpetruc added a commit to gpetruc/cmssw that referenced this pull request Aug 4, 2021
@gpetruc
Merge tag 'l1t-phase2-v3.3.39' into update_upstream_39
8653dc8 
Et Miss Emulator default track collection fix (cms-sw#935)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pending-signatures reconstruction-pending tests-approved
Projects
None yet
Milestone
CMSSW_7_0_0_pre5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ktf @cmsbuild @thspeer @nclopezo @ptcox