Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataFormats/HGCDigi: remove HGCEEDetId and HGCHEDetId #9356

Merged
merged 1 commit into from May 30, 2015
Merged

DataFormats/HGCDigi: remove HGCEEDetId and HGCHEDetId #9356

merged 1 commit into from May 30, 2015

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented May 30, 2015

HGCEEDetId and HGCHEDetId are provided by different dictionary and
ROOT will load those based on rootmap files. These classes are part of
DataFormats/ForwardDetId dictionary.

Fixes 7 failing unit tests.

Fatal exception is throw if both dictionaries are loaded in cmsRun process due
to duplication.

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

DataFormats/HGCDigi: remove HGCEEDetId and HGCHEDetId
9d77a98 
`HGCEEDetId` and `HGCHEDetId` are provided by different dictionary and
ROOT will load those based on rootmap files. These classes are part of
DataFormats/ForwardDetId dictionary.

Fixes 7 failing unit tests.

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone May 30, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlt for CMSSW_7_5_X.

DataFormats/HGCDigi: remove HGCEEDetId and HGCHEDetId

It involves the following packages:

DataFormats/HGCDigi

The following packages do not have a category, yet:

DataFormats/HGCDigi

@cmsbuild can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@davidlt
Copy link
Contributor Author

davidlt commented May 30, 2015

@davidlange6 this package is not yet assigned to any category. To which categories it should be added?

@cmsbuild
Copy link
Contributor

+1
Tested at: 9d77a98
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9356/5179/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
c8d4780
d3cd3df
cf30f06
459c443
2bb975b
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9356/5179/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9356/5179/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9356/5179/summary.html

@davidlt davidlt mentioned this pull request May 30, 2015
Merged
@davidlange6
Copy link
Contributor

actually I didn't know we had a DataFormats/Forward* already. If so we don't need this new package, and Sunanda should move things there (or move forward to here). I'll merge this and then discuss with Sunanda next week.

davidlange6 added a commit that referenced this pull request May 30, 2015
@davidlange6
Merge pull request #9356 from davidlt/remove-HGCHEDetId-HGCEEDetId
aa6a164 
DataFormats/HGCDigi: remove HGCEEDetId and HGCHEDetId
@davidlange6 davidlange6 merged commit aa6a164 into cms-sw:CMSSW_7_5_X May 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available new-package-pending orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
CMSSW_7_5_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davidlt @cmsbuild @davidlange6