Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CondFormats/SiStripObjects: clean dictionary of duplicate selection rules #9371

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented May 31, 2015

Thanks to Danilo ROOT 6.04.00 will have user-friendly duplicate
selection rule check.

Warning: Selection file classes_def.xml, lines 13 and 11. Attempt to
select with a named selection rule an already selected class. The name
used in the selection is "SiStripFedCabling::Conns" while the class is
"vector<FedChannelConnection>".

Warning: Selection file classes_def.xml, lines 37 and 34. Attempt to
select with a named selection rule an already selected class. The name
used in the selection is "SiStripThreshold::Container" while the class
is "vector<SiStripThreshold::Data>".

Tested by comparing seal_cap.cc, which does not change after this
patchset.

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

…ules

Thanks to Danilo ROOT 6.04.00 will have user-friendly duplicate
selection rule check.

    Warning: Selection file classes_def.xml, lines 13 and 11. Attempt to
    select with a named selection rule an already selected class. The name
    used in the selection is "SiStripFedCabling::Conns" while the class is
    "vector<FedChannelConnection>".

    Warning: Selection file classes_def.xml, lines 37 and 34. Attempt to
    select with a named selection rule an already selected class. The name
    used in the selection is "SiStripThreshold::Container" while the class
    is "vector<SiStripThreshold::Data>".

Tested by comparing `seal_cap.cc`, which does not change after this
patchset.

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlt for CMSSW_7_5_X.

CondFormats/SiStripObjects: clean dictionary of duplicate selection rules

It involves the following packages:

CondFormats/SiStripObjects

@ggovi, @cmsbuild, @mmusich, @diguida, @cerminar can you please review it and eventually sign? Thanks.
@apfeiffer1, @VinInn, @threus, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

davidlange6 added a commit that referenced this pull request May 31, 2015
…s-SiStripObjects

CondFormats/SiStripObjects: clean dictionary of duplicate selection rules
@davidlange6 davidlange6 merged commit 4dd5996 into cms-sw:CMSSW_7_5_X May 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants