Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CondFormats/EcalObjects: clean dictionary of duplicate selection rules #9372

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented May 31, 2015

Thanks to Danilo ROOT 6.04.00 will have user-friendly duplicate
selection rule check.

The amount of warnings are too high to put them into a commit message.

seal_cap.cc was checked after re-compilation and none of types were
removed from the dictionary.

Full list of warnings:

Warning: Selection file classes_def.xml, lines 164 and 159. Attempt to select with a named selection rule an already selected class. The name used in the selection is "EcalFloatCondObjectContainer" while the class is "EcalCondObjectContainer<float>".
Warning: Selection file classes_def.xml, lines 99 and 94. Attempt to select with a named selection rule an already selected class. The name used in the selection is "EcalPedestals" while the class is "EcalCondObjectContainer<EcalPedestal>".
Warning: Selection file classes_def.xml, lines 153 and 148. Attempt to select with a named selection rule an already selected class. The name used in the selection is "EcalWeightXtalGroups" while the class is "EcalCondObjectContainer<EcalXtalGroupId>".
Warning: Selection file classes_def.xml, lines 73 and 68. Attempt to select with a named selection rule an already selected class. The name used in the selection is "EcalGainRatios" while the class is "EcalCondObjectContainer<EcalMGPAGainRatio>".
Warning: Selection file classes_def.xml, lines 165 and 164. Attempt to select with a named selection rule an already selected class. The name used in the selection is "EcalIntercalibConstants" while the class is "EcalCondObjectContainer<float>".
Warning: Selection file classes_def.xml, lines 166 and 165. Attempt to select with a named selection rule an already selected class. The name used in the selection is "EcalIntercalibConstantsMC" while the class is "EcalCondObjectContainer<float>".
Warning: Selection file classes_def.xml, lines 167 and 166. Attempt to select with a named selection rule an already selected class. The name used in the selection is "EcalIntercalibErrors" while the class is "EcalCondObjectContainer<float>".
Warning: Selection file classes_def.xml, lines 304 and 299. Attempt to select with a named selection rule an already selected class. The name used in the selection is "EcalPulseShapes" while the class is "EcalCondObjectContainer<EcalPulseShape>".
Warning: Selection file classes_def.xml, lines 317 and 312. Attempt to select with a named selection rule an already selected class. The name used in the selection is "EcalPulseCovariances" while the class is "EcalCondObjectContainer<EcalPulseCovariance>".
Warning: Selection file classes_def.xml, lines 170 and 167. Attempt to select with a named selection rule an already selected class. The name used in the selection is "EcalTimeCalibConstants" while the class is "EcalCondObjectContainer<float>".
Warning: Selection file classes_def.xml, lines 171 and 170. Attempt to select with a named selection rule an already selected class. The name used in the selection is "EcalTimeCalibErrors" while the class is "EcalCondObjectContainer<float>".
Warning: Selection file classes_def.xml, lines 23 and 11. Attempt to select with a named selection rule an already selected class. The name used in the selection is "EcalChannelStatus" while the class is "EcalCondObjectContainer<EcalChannelStatusCode>".
Warning: Selection file classes_def.xml, lines 60 and 53. Attempt to select with a named selection rule an already selected class. The name used in the selection is "EcalDQMTowerStatus" while the class is "EcalCondTowerObjectContainer<EcalDQMStatusCode>".
Warning: Selection file classes_def.xml, lines 58 and 46. Attempt to select with a named selection rule an already selected class. The name used in the selection is "EcalDQMChannelStatus" while the class is "EcalCondObjectContainer<EcalDQMStatusCode>".
Warning: Selection file classes_def.xml, lines 25 and 18. Attempt to select with a named selection rule an already selected class. The name used in the selection is "EcalDCSTowerStatus" while the class is "EcalCondTowerObjectContainer<EcalChannelStatusCode>".
Warning: Selection file classes_def.xml, lines 38 and 33. Attempt to select with a named selection rule an already selected class. The name used in the selection is "EcalDAQTowerStatus" while the class is "EcalCondTowerObjectContainer<EcalDAQStatusCode>".
Warning: Selection file classes_def.xml, lines 169 and 171. Attempt to select with a named selection rule an already selected class. The name used in the selection is "EcalLaserAlphas" while the class is "EcalCondObjectContainer<float>".
Warning: Selection file classes_def.xml, lines 208 and 203. Attempt to select with a named selection rule an already selected class. The name used in the selection is "EcalTimeDependentCorrections::EcalValueMap" while the class is "EcalCondObjectContainer<EcalTimeDependentCorrections::Values>".
Warning: Selection file classes_def.xml, lines 190 and 185. Attempt to select with a named selection rule an already selected class. The name used in the selection is "EcalLaserAPDPNRatios::EcalLaserAPDPNRatiosMap" while the class is "EcalCondObjectContainer<EcalLaserAPDPNRatios::EcalLaserAPDPNpair>".
Warning: Selection file classes_def.xml, lines 211 and 195. Attempt to select with a named selection rule an already selected class. The name used in the selection is "EcalLinearCorrections" while the class is "EcalTimeDependentCorrections".
Warning: Selection file classes_def.xml, lines 168 and 169. Attempt to select with a named selection rule an already selected class. The name used in the selection is "EcalLaserAPDPNRatiosRef" while the class is "EcalCondObjectContainer<float>".
Warning: Selection file classes_def.xml, lines 127 and 122. Attempt to select with a named selection rule an already selected class. The name used in the selection is "EcalTPGLinearizationConst" while the class is "EcalCondObjectContainer<EcalTPGLinearizationConstant>".
Warning: Selection file classes_def.xml, lines 140 and 135. Attempt to select with a named selection rule an already selected class. The name used in the selection is "EcalTPGPedestals" while the class is "EcalCondObjectContainer<EcalTPGPedestal>".
Warning: Selection file classes_def.xml, lines 86 and 81. Attempt to select with a named selection rule an already selected class. The name used in the selection is "EcalMappingElectronics" while the class is "EcalCondObjectContainer<EcalMappingElement>".
Warning: Selection file classes_def.xml, lines 233 and 227. Attempt to select with a named selection rule an already selected class. The name used in the selection is "EcalClusterLocalContCorrParameters" while the class is "EcalFunParams".
Warning: Selection file classes_def.xml, lines 229 and 233. Attempt to select with a named selection rule an already selected class. The name used in the selection is "EcalClusterCrackCorrParameters" while the class is "EcalFunParams".
Warning: Selection file classes_def.xml, lines 231 and 229. Attempt to select with a named selection rule an already selected class. The name used in the selection is "EcalClusterEnergyCorrectionParameters" while the class is "EcalFunParams".
Warning: Selection file classes_def.xml, lines 232 and 231. Attempt to select with a named selection rule an already selected class. The name used in the selection is "EcalClusterEnergyUncertaintyParameters" while the class is "EcalFunParams".
Warning: Selection file classes_def.xml, lines 230 and 232. Attempt to select with a named selection rule an already selected class. The name used in the selection is "EcalClusterEnergyCorrectionObjectSpecificParameters" while the class is "EcalFunParams".
Warning: Selection file classes_def.xml, lines 114 and 109. Attempt to select with a named selection rule an already selected class. The name used in the selection is "EcalTPGCrystalStatus" while the class is "EcalCondObjectContainer<EcalTPGCrystalStatusCode>".

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

Thanks to Danilo ROOT 6.04.00 will have user-friendly duplicate
selection rule check.

The amount of warnings are too high to put them into a commit message.

`seal_cap.cc` was checked after re-compilation and none of types were
removed from the dictionary.

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlt for CMSSW_7_5_X.

CondFormats/EcalObjects: clean dictionary of duplicate selection rules

It involves the following packages:

CondFormats/EcalObjects

@ggovi, @cmsbuild, @mmusich, @diguida, @cerminar can you please review it and eventually sign? Thanks.
@apfeiffer1, @argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@diguida
Copy link
Contributor

diguida commented Jun 5, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants