Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependencies between DataFormats #9373

Merged

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented May 31, 2015

According to IB logs ROOT6 run-time is not able to locate some
classes and dictionaries. The patch adds missing dependencies based on
ROOT6 run-time errors and warnings printed while building CMSSW IB.

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

According to IB logs ROOT6 run-time is not able to locate some
classes and dictionaries. The patch adds missing dependencies based on
ROOT6 run-time errors and warnings printed by building CMSSW IB.

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlt for CMSSW_7_5_X.

Fix dependencies between DataFormats

It involves the following packages:

DataFormats/EgammaTrackReco
DataFormats/METReco
DataFormats/MuonSeed
DataFormats/TrackCandidate
DataFormats/TrajectorySeed
FastSimDataFormats/External

@civanch, @lveldere, @cvuosalo, @ssekmen, @mdhildreth, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @jdolen, @battibass, @makortel, @abbiendi, @mmarionncern, @jhgoh, @VinInn, @ahinzmann, @nhanvtran, @schoef, @gpetruc, @mariadalfonso, @trocino, @TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@lveldere
Copy link
Contributor

lveldere commented Jun 4, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants