Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataFormats/CaloTowers: add missing class #9380

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Jun 1, 2015

While building CMSSW the following warning is generated by ROOT6
run-time:

TClass::Init:0: RuntimeWarning: no dictionary for class
edm::AtomicPtrCache<vector<edm::Ptr<CaloTower> > > is available

Add missing class edm::AtomicPtrCache<vector<edm::Ptr<CaloTower> > >

The only user of this is DataFormats/PatCandidates.

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

While building CMSSW the following warning is generated by ROOT6
run-time:

    TClass::Init:0: RuntimeWarning: no dictionary for class
    edm::AtomicPtrCache<vector<edm::Ptr<CaloTower> > > is available

Add missing class edm::AtomicPtrCache<vector<edm::Ptr<CaloTower> > >

The only user of this is `DataFormats/PatCandidates`.

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2015

A new Pull Request was created by @davidlt for CMSSW_7_5_X.

DataFormats/CaloTowers: add missing class

It involves the following packages:

DataFormats/CaloTowers
DataFormats/PatCandidates

@cmsbuild, @cvuosalo, @vadler, @monttj, @slava77 can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2015

-1
Tested at: eea5a78
The relvals timed out after 2 hours.

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9380/7977/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
3194756
67f8f06
f8dd2ef
ca73bbc
3426948
71306a2
b04f79f
4dd5996
cf1a323
83e4065
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9380/7977/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9380/7977/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2015

@slava77
Copy link
Contributor

slava77 commented Jun 3, 2015

+1

for #9380 eea5a78

  • code changes are OK, although it's ironic to fix ROOT-6 issues with and addition of a comment the declaration of AtomicPtrCache are a temporary work around until ROOT 6 where they will not be needed
  • jenkins tests pass OK, but comparisons are not ready still
  • tested locally in CMSSW_7_5_X_2015-06-03-1100 /sign559/ and observe no differences in comparisons with the baseline

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2015

@smuzaffar
Copy link
Contributor

this link is broken , i guess the reason is that the release used for
running the ib-integration test and comparison were different. I am
re-running the comparison using the same release which was used to run
the ib-integration now.
On 06/04/2015 11:06 AM, cmsbuild wrote:

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9380/5221/summary.html


Reply to this email directly or view it on GitHub
#9380 (comment).

@smuzaffar
Copy link
Contributor

forget my previous comment. It turned out fixing the link was much easier/faster then re-running the comparison. Above comparison link is all good now

davidlange6 added a commit that referenced this pull request Jun 6, 2015
…aloTowers

DataFormats/CaloTowers: add missing class
@davidlange6 davidlange6 merged commit 517c9b2 into cms-sw:CMSSW_7_5_X Jun 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants