Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix for the deprecation of kCanRebin. Migration to conddb v2. New macros and configuration to analyze out of time pileup #9392

Merged
merged 12 commits into from Jun 17, 2015
Merged

Bug fix for the deprecation of kCanRebin. Migration to conddb v2. New macros and configuration to analyze out of time pileup #9392

merged 12 commits into from Jun 17, 2015

Conversation

venturia
Copy link
Contributor

@venturia venturia commented Jun 1, 2015

No description provided.

@venturia
Adjustments in the configuration to produce and test APV cycle phase …
8493ef4 
…offset payloads
@venturia
Script to harvest and merge root files from a crab job res directory
7826476
@venturia
New configuration to study cosmic events
0340693
@venturia
Migration to conddb v2
738c1a5
@venturia
more details in a warning message
872a39d
@venturia
New macros for the OOT fraction analysis
052cce2 
Conflicts:
	DPGAnalysis/SiStripTools/bin/DPGAnalysisSiStripToolsMacrosLinkDef.h
@venturia
Added new histogram of occupancy vs BX number both per run and per fill
3b241b5 
Conflicts:
	DPGAnalysis/SiStripTools/plugins/MultiplicityInvestigator.cc
	DPGAnalysis/SiStripTools/src/DigiInvestigatorHistogramMaker.cc
@venturia
New configuration for the OOT fraction analysis
2254a6d
@venturia
Migration to conddb v2
c94e006
@venturia
Replace kCanRebin with SetCanExtend
dbd3e09
@venturia
Update of the crab configurations
48c9590
@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Jun 1, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2015

A new Pull Request was created by @venturia for CMSSW_7_4_X.

Bug fix for the deprecation of kCanRebin. Migration to conddb v2. New macros and configuration to analyze out of time pileup

It involves the following packages:

DPGAnalysis/SiStripTools

@cmsbuild, @vadler, @monttj can you please review it and eventually sign? Thanks.
@threus this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@venturia
Copy link
Contributor Author

venturia commented Jun 2, 2015

I have added a commit to fix the kCanRebin deprecation also in Validation/RecoVertex

@monttj
Copy link
Contributor

monttj commented Jun 17, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Jun 17, 2015
@cmsbuild
Merge pull request #9392 from venturia/dpganalysis_sistriptools-74x
6f87950 
Bug fix for the deprecation of kCanRebin. Migration to conddb v2. New macros and configuration to analyze out of time pileup
@cmsbuild cmsbuild merged commit 6f87950 into cms-sw:CMSSW_7_4_X Jun 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-approved comparison-available dqm-approved fully-signed tests-approved
Projects
None yet
Milestone
Next CMSSW_7_4_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@venturia @cmsbuild @deguio @monttj @davidlange6