Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add luminibble unpacker #9394

Merged
merged 8 commits into from Jun 12, 2015

Conversation

capalmer85
Copy link
Contributor

This module works and is safe, but it does not get into the Events tree. How should we go about that?

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2015

A new Pull Request was created by @capalmer85 for CMSSW_7_5_X.

Add luminibble unpacker

It involves the following packages:

Configuration/StandardSequences
EventFilter/Utilities

@mommsen, @cmsbuild, @franzoni, @emeschi, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @appeltel, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @cerati, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mommsen
Copy link
Contributor

mommsen commented Jun 2, 2015

+1

@davidlange6
Copy link
Contributor

@capalmer85 - thinking ahead - could we give this producer a more generic name - such as LumiRawToDigi (both in C++ and python)?

To save the product, you need to add it to Configuration/EventContent (you should make a new cff following the examples in the existing cffs)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2015

Pull request #9394 was updated. @mommsen, @cmsbuild, @franzoni, @emeschi, @davidlange6 can you please check and sign again.

@capalmer85
Copy link
Contributor Author

I was using an event content in my cfg that I hadn't added the TcdsEventContent to. I've fixed that and a typo in a filename (Tcsd --> Tcds). I think this is finally done now.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants