Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for crash in 140.0: remove PostLS1_HI customization from legacy HI workflow #9487

Merged
merged 2 commits into from Jun 16, 2015

Conversation

kkrajczar
Copy link
Contributor

Dear all,

The purpose of this PR is to fix a crash [1] arising from the mixing of the Run-2 conditions and the Run-1 GT. In this PR, we remove the postLS1_HI customization and switch the HLT menu from HIon (which relied on the PostLS1_HI customization) to the fake HLT menu in workflow 140.0. In my tests, this PR solves the crash.

Cheers,
Krisztian

[1] An exception of category 'CorrelatedNoisifier' occurred while
[0] Processing run: 1 lumi: 36 event: 36
[1] Running path 'digitisation_step'
[2] Calling event method for module CSCDigiProducer/'simMuonCSCDigis'

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2015

A new Pull Request was created by @kkrajczar (Krisztian Krajczar) for CMSSW_7_5_X.

Fix for crash in 140.0: remove PostLS1_HI customization from legacy HI workflow

It involves the following packages:

Configuration/PyReleaseValidation

@cmsbuild, @srimanob, @boudoul, @franzoni can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@franzoni
Copy link

hello @kkrajczar ,
with the wf 140 being in full a runI workflow, your change is a correction of a mistake (thanks).

However, is there any wf for HIN in runII conditons ? Can you please make a proposal - we'd need to keep the new centre of mass energy, geomety, AlCal, and customize function validated for runII.

Cheers and thanks,
g.

@franzoni
Copy link

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@kkrajczar
Copy link
Contributor Author

Hi Giovanni,

We have a run2 workflow with new center-of-mass energy, geometry, etc: wf 145; it is already in the matrix.

Cheers,
Krisztian

-------- Original message --------
From: Giovanni Franzoni
Date:12/06/2015 15:45 (GMT+01:00)
To: cms-sw/cmssw
Cc: Krisztian Krajczar
Subject: Re: [cmssw] Fix for crash in 140.0: remove PostLS1_HI customization from legacy HI workflow (#9487)

hello @kkrajczarhttps://github.com/kkrajczar ,
with the wf 140 being in full a runI workflow, your change is a correction of a mistake (thanks).

However, is there any wf for HIN in runII conditons ? Can you please make a proposal - we'd need to keep the new centre of mass energy, geomety, AlCal, and customize function validated for runII.

Cheers and thanks,
g.


Reply to this email directly or view it on GitHubhttps://github.com//pull/9487#issuecomment-111497029.

@cmsbuild
Copy link
Contributor

@franzoni
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants