New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean unsused selection rules (ROOT 6.04.00) #9492
Clean unsused selection rules (ROOT 6.04.00) #9492
Conversation
`edm::KeyVal` never existed, it was `edm::helpers::KeyVal`. As these never were selected -- remove. Enabling them in 6 packages with a corrected name would create duplicate types in dictionaries. The following types: - `edm::RefVector<edm::AssociationMap*` - `edm::RefProd<edm::AssociationMap*` - `edm::Ref<edm::AssociationMap*` do not exist in `DataFormats/RecoCandidate` and `DataFormats/TrackReco` dictionary translation units. Similar rules exist in `DataFormats/TrackCandidate`, but in this package `genreflex` does select them. Due to regression in ROOT6 `genreflex` these warnings are temporarely non fatal. CMS makes `genreflex` to fail on any warning by default. This is already fixed in ROOT6 master branch. Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
A new Pull Request was created by @davidlt for CMSSW_7_5_X. Clean unsused selection rules (ROOT 6.04.00) It involves the following packages: AnalysisDataFormats/Egamma @cmsbuild, @cvuosalo, @vadler, @monttj, @slava77 can you please review it and eventually sign? Thanks. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Clean unsused selection rules (ROOT 6.04.00)
edm::KeyVal
never existed, it wasedm::helpers::KeyVal
. As thesenever were selected -- remove. Enabling them in 6 packages with a
corrected name would create duplicate types in dictionaries.
The following types:
edm::RefVector<edm::AssociationMap*
edm::RefProd<edm::AssociationMap*
edm::Ref<edm::AssociationMap*
do not exist in
DataFormats/RecoCandidate
andDataFormats/TrackReco
dictionary translation units. Similar rules exist in
DataFormats/TrackCandidate
, but in this packagegenreflex
does selectthem.
Due to regression in ROOT6
genreflex
these warnings are temporarelynon fatal. CMS makes
genreflex
to fail on any warning by default. Thisis already fixed in ROOT6 master branch.
Would be happy if a second pair of eyes would double check.
@wmtan
Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch