Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean unsused selection rules (ROOT 6.04.00) #9492

Merged
merged 1 commit into from Jun 8, 2015

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Jun 8, 2015

edm::KeyVal never existed, it was edm::helpers::KeyVal. As these
never were selected -- remove. Enabling them in 6 packages with a
corrected name would create duplicate types in dictionaries.

The following types:

  • edm::RefVector<edm::AssociationMap*
  • edm::RefProd<edm::AssociationMap*
  • edm::Ref<edm::AssociationMap*

do not exist in DataFormats/RecoCandidate and DataFormats/TrackReco
dictionary translation units. Similar rules exist in
DataFormats/TrackCandidate, but in this package genreflex does select
them.

Due to regression in ROOT6 genreflex these warnings are temporarely
non fatal. CMS makes genreflex to fail on any warning by default. This
is already fixed in ROOT6 master branch.

Would be happy if a second pair of eyes would double check.

@wmtan

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

`edm::KeyVal` never existed, it was `edm::helpers::KeyVal`. As these
never were selected -- remove. Enabling them in 6 packages with a
corrected name would create duplicate types in dictionaries.

The following types:
- `edm::RefVector<edm::AssociationMap*`
- `edm::RefProd<edm::AssociationMap*`
- `edm::Ref<edm::AssociationMap*`

do not exist in `DataFormats/RecoCandidate` and `DataFormats/TrackReco`
dictionary translation units. Similar rules exist in
`DataFormats/TrackCandidate`, but in this package `genreflex` does select
them.

Due to regression in ROOT6 `genreflex` these warnings are temporarely
non fatal. CMS makes `genreflex` to fail on any warning by default. This
is already fixed in ROOT6 master branch.

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2015

A new Pull Request was created by @davidlt for CMSSW_7_5_X.

Clean unsused selection rules (ROOT 6.04.00)

It involves the following packages:

AnalysisDataFormats/Egamma
DataFormats/EgammaReco
DataFormats/RecoCandidate
DataFormats/TrackCandidate
DataFormats/TrackReco
TrackingTools/PatternTools

@cmsbuild, @cvuosalo, @vadler, @monttj, @slava77 can you please review it and eventually sign? Thanks.
@Sam-Harper, @battibass, @makortel, @abbiendi, @GiacomoSguazzoni, @jhgoh, @lgray, @appeltel, @bellan, @rovere, @gpetruc, @cerati, @VinInn, @trocino, @dgulhan, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2015

@cvuosalo
Copy link
Contributor

cvuosalo commented Jun 8, 2015

+1

For #9492 0936023

Clean-up of unused selection rules to eliminate ROOT6.04 error messages. There should be no change in run-time behavior.

Jenkins tests against baseline CMSSW_7_5_X_2015-06-06-2300 show no significant differences, as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants