Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimDataFormats/Vertex: clean unused pattern-based selection rules #9497

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Jun 8, 2015

The following two types:

  • edm::Ref<std::vector<SimVertex>,*>
  • edm::RefVector<std::vector<SimVertex>,*>

are unused by ROOT6, but ROOT5 manages to selected classes with them.

The actual types selected are:

  • edm::SimVertexRef
  • edm::SimVertexRefVector

which are already listed in classes.h file.

The patch will bring back the missing types to ROOT6 dictionary and
change is ROOT5 compatible.

The difference in ROOT6 dictionary after modification:

--- seal_cap.cc.orig    2015-06-08 14:51:16.992555582 +0200
+++ tmp/slc6_amd64_gcc491/src/SimDataFormats/Vertex/src/SimDataFormatsVertex/a/seal_cap.cc      2015-06-08 14:53:26.006608002 +0200
@@ -3,8 +3,12 @@
  "LCGReflex/vector<SimVertex>",
  "LCGReflex/CoreSimVertex",
  "LCGReflex/SimVertex",
+ "LCGReflex/edm::Ref<std::vector<SimVertex>,SimVertex,edm::refhelper::FindUsingAdvance<std::vector<SimVertex>,SimVertex> >",
+ "LCGReflex/edm::Ref<vector<SimVertex>,SimVertex,edm::refhelper::FindUsingAdvance<vector<SimVertex>,SimVertex> >",
  "LCGReflex/std::vector<const SimVertex*>",
  "LCGReflex/vector<const SimVertex*>",
+ "LCGReflex/edm::RefVector<std::vector<SimVertex>,SimVertex,edm::refhelper::FindUsingAdvance<std::vector<SimVertex>,SimVertex> >",
+ "LCGReflex/edm::RefVector<vector<SimVertex>,SimVertex,edm::refhelper::FindUsingAdvance<vector<SimVertex>,SimVertex> >",
  "LCGReflex/edm::RefProd<std::vector<SimVertex> >",
  "LCGReflex/edm::RefProd<vector<SimVertex> >",
  "LCGReflex/edm::Wrapper<std::vector<SimVertex> >",

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

The following two types:
- `edm::Ref<std::vector<SimVertex>,*>`
- `edm::RefVector<std::vector<SimVertex>,*>`

are unused by ROOT6, but ROOT5 manages to selected classes with them.

The actual types selected are:
- `edm::SimVertexRef`
- `edm::SimVertexRefVector`

which are already listed in `classes.h` file.

The patch will bring back the missing types to ROOT6 dictionary and
change is ROOT5 compatible.

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2015

A new Pull Request was created by @davidlt for CMSSW_7_5_X.

SimDataFormats/Vertex: clean unused pattern-based selection rules

It involves the following packages:

SimDataFormats/Vertex

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2015

davidlange6 added a commit that referenced this pull request Jun 8, 2015
…ats-Vertex

SimDataFormats/Vertex: clean unused pattern-based selection rules
@davidlange6 davidlange6 merged commit 2df0c13 into cms-sw:CMSSW_7_5_X Jun 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants